Skip to content

[part 1] [debug mode] provide runtime support #2771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 29, 2018
Merged

[part 1] [debug mode] provide runtime support #2771

merged 2 commits into from
Apr 29, 2018

Conversation

bobzhang
Copy link
Member

@bobzhang bobzhang commented Apr 26, 2018 •
edited
Loading

it almost works except:

  • do we need modify Array.prototype.toString, String.prototype.toString (need escape ""),
    • if we use chrome debugger, maybe not?
    • if we modify Array(Caml_block vs Array), we need instrument dependency

TODO:

  • investigate chrome customized printer again
  • How toString changes will affect string interpolation and functions relying on "" +

@bobzhang bobzhang merged commit 8a31d02 into master Apr 29, 2018
@bobzhang bobzhang deleted the debug branch April 29, 2018 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bobzhang