Skip to content

Upgrade debug mode to adapt the changes of local module representation #3837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 21, 2019
Merged

Upgrade debug mode to adapt the changes of local module representation #3837

merged 4 commits into from
Sep 21, 2019

Conversation

bobzhang
Copy link
Member

cristianoc
cristianoc reviewed Sep 21, 2019
View reviewed changes
jscomp/others/belt_Debug.mli Outdated


val setupChromeDebugger : unit -> unit
[@@ocaml.deprecated "This call is reduandent, simply remoe it"]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: redundant

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: remove

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed, thanks

@bobzhang bobzhang merged commit 00ad78c into master Sep 21, 2019
@bobzhang bobzhang deleted the upgrade_debug_mode branch September 21, 2019 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cristianoc cristianoc cristianoc left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bobzhang @cristianoc