Skip to content

update a fix in ocaml compiler patch, not looking up aggressive #3874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 15, 2019
Merged

update a fix in ocaml compiler patch, not looking up aggressive #3874

merged 1 commit into from
Oct 15, 2019

Conversation

bobzhang
Copy link
Member

No description provided.

@cristianoc
Copy link
Collaborator

Curious about what this change does.
Looks like generates files are not affected.

@bobzhang
Copy link
Member Author

Curious about what this change does.
Looks like generates files are not affected.

The patch introduced is buggy since module A = B, with B as Pident id does not ensure that B is a global module. I spotted the issue when removing -no-alias-deps

@bobzhang bobzhang merged commit 2cc36bf into master Oct 15, 2019
@bobzhang bobzhang deleted the upgrade_ocaml_compiler_fix branch October 15, 2019 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bobzhang @cristianoc