Skip to content

Make node process exit return 'a instead of unit #4100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 18, 2020
Merged

Make node process exit return 'a instead of unit #4100

merged 1 commit into from
Jan 18, 2020

Conversation

sawoz
Copy link
Contributor

@sawoz sawoz commented Jan 16, 2020 •
edited
Loading

Hi,

I've just noticed that the exit function in Node process returns unit.
Since this function terminates the process, I would expect that 'a is more appropriate here.

What do you think?

Sander

@sawoz sawoz requested a review from bobzhang January 16, 2020 14:20
@bobzhang
Copy link
Member

looks good to me and a non breaking change, thanks

@bobzhang bobzhang merged commit 28589d8 into rescript-lang:master Jan 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobzhang bobzhang Awaiting requested review from bobzhang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sawoz @bobzhang