smooth transition between bs.inline and inline #4700
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- since it's going to be transformed anyway, the remained will be unused in the future, for inline attributes, either it's transformed right away, or left for function ``` let f = 1 + 2 [@@inline] ``` The upstream compiler still emit a warning here: the "inline" attribute can not appear hear
the current status: unused bs.inline for sure will be detected unused inline depends on how smart the upstream compiler is
since we are going to drop those attribute, we need know if it is used or not
let f = 1 + 3 [@@bs.inline] will emit a warning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.