[Super errors] better arity mismatch error for uncurried function #4940
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Before: After: |
chenglou
commented
Feb 7, 2021
| (_, {desc = Tconstr (Pdot (Pdot(Pident {name = "Js"},"Fn",_),a,_),_,_)}) :: | ||
| (_, {desc = Tconstr (Pdot (Pdot(Pident {name = "Js"},"Fn",_),b,_),_,_)}) :: _ | ||
| ) when a <> b -> | ||
| let extractArity s = |
There was a problem hiding this comment.
Is this too weird? Should I just pattern match all the way from arity0 to arity22?
There was a problem hiding this comment.
pattern match all the way from arity0 to arity22 that would be an explosion of pattern match
There was a problem hiding this comment.
why it is still sound ? since we own the Js.Fn module which only contains type definitions for arity*
There was a problem hiding this comment.
- can you extract this into a toplevel function parameterized by
aandbso that it can be reused later (for other syntaxes as well)? - this looks like the same pattern match in loc 185-188, so you should merge it there
- I also think that
a <> bseems to be not necessary since whena = b, there should be no such error message
bobzhang
reviewed
Feb 10, 2021
| This function expected 2 arguments, but got 3 |
There was a problem hiding this comment.
the rephrase of such error message looks great
chenglou
force-pushed
the
arity-se
branch
3 times, most recently
from
458fb64 to
9b92bb7
Compare
Fixes rescript-lang#4939 The previous message was also wrong (?). The types were flipped; if the function expected 1 and got 2, it'd say "this function has arity2 but was expected arity1".
bobzhang
reviewed
Feb 18, 2021
| (* assumption: the module Js.Fn only contains types from arity0 to arity22 *) | ||
| String.sub s 5 ((String.length s) - 5) | ||
| else | ||
| raise (Invalid_argument "Unrecognized arity type name.") |
There was a problem hiding this comment.
nitpicks: this should be assert false
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4939
The previous message was also wrong (?). The types were flipped; if the
function expected 1 and got 2, it'd say "this function has arity2 but
was expected arity1".