Skip to content

fix #5525 #5526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 9, 2022
Merged

fix #5525 #5526

merged 3 commits into from
Jul 9, 2022

Conversation

fhammerschmidt
Copy link
Member

No description provided.

cristianoc
cristianoc reviewed Jul 9, 2022
View reviewed changes
Copy link
Collaborator

@cristianoc cristianoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thank you for the fix.

OK so requiring a non-existing file is actually an error in itself.

@cristianoc
Copy link
Collaborator

cristianoc commented Jul 9, 2022 •
edited
Loading

Good catch, thank you for the fix.

OK so requiring a non-existing file is actually an error in itself.

I should not review straight JS code without knowing this 😿

@cristianoc cristianoc merged commit 1182408 into rescript-lang:master Jul 9, 2022
@cristianoc cristianoc mentioned this pull request Sep 20, 2022
Closed
29 tasks
@fhammerschmidt fhammerschmidt deleted the patch-1 branch January 19, 2023 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cristianoc cristianoc cristianoc left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fhammerschmidt @cristianoc