Skip to content

Clean up platform bin dirs part 1: ninja.COPYING #5676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 20, 2022
Merged

Clean up platform bin dirs part 1: ninja.COPYING #5676

merged 4 commits into from
Sep 20, 2022

Conversation

cknitt
Copy link
Member

@cknitt cknitt commented Sep 20, 2022 •
edited
Loading

First step to clean up what's left of the platform bin dirs.

  • Create (current) platform bin dir automatically if it does not exist yet when building the ninja binary.
  • Remove all those copies of ninja.COPYING and instead add a single one when creating the npm package.
  • Also remove openbsd/.keep.

@cknitt cknitt force-pushed the cleanup-ninja-copying branch from 594dd47 to 8a7c3dc Compare September 20, 2022 06:45
@cknitt cknitt changed the title Test cleanup ninja copying Cleanup platform bin dirs part 1: ninja.COPYING Sep 20, 2022
@cknitt cknitt requested a review from cristianoc September 20, 2022 06:56
@cknitt cknitt changed the title Cleanup platform bin dirs part 1: ninja.COPYING Clean up platform bin dirs part 1: ninja.COPYING Sep 20, 2022
@cknitt cknitt marked this pull request as ready for review September 20, 2022 06:58
@cknitt cknitt merged commit b367be5 into rescript-lang:master Sep 20, 2022
@cknitt cknitt deleted the cleanup-ninja-copying branch September 20, 2022 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cristianoc cristianoc cristianoc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cknitt @cristianoc