Skip to content

Fix description for warning number 110 #6725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 16, 2024
Merged

Fix description for warning number 110 #6725

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7b355a7
Fix description for warning number 110
fhammerschmidt Apr 16, 2024
2e811a2
Changelog
fhammerschmidt Apr 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
- Stop escaping JSX prop names with hyphens. https://github.com/rescript-lang/rescript-compiler/pull/6705
- Fix trailing undefined for optional parameters not omitted with `@send` and `@new`. https://github.com/rescript-lang/rescript-compiler/pull/6716
- Fix JSX4 adding the incorrect type annotation for the prop `ref` in React.forwardRef component https://github.com/rescript-lang/rescript-compiler/pull/6718
- Fix description for warning number 110 https://github.com/rescript-lang/rescript-compiler/pull/6725

#### :nail_care: Polish

Expand Down
2 changes: 1 addition & 1 deletion jscomp/ext/warnings.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -647,7 +647,7 @@ let descriptions =
);
(108, "Uninterpreted delimiters (for unicode)");
(109, "Toplevel expression has unit type");
(110, "Expression has nested promise type");
(110, "Todo found");
]

let help_warnings () =
Expand Down