Skip to content

Add Js.globalThis object binding #6909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 29, 2024
Merged

Add Js.globalThis object binding #6909

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
df07a05
Add `Js.globalThis` object binding
cometkim Jul 24, 2024
1b9a504
changelog
cometkim Jul 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
- Allow `private` in with constraints. https://github.com/rescript-lang/rescript-compiler/pull/6843
- Add regex literals as syntax sugar for `@bs.re`. https://github.com/rescript-lang/rescript-compiler/pull/6776
- Improved mechanism to determine arity of externals, which is consistent however the type is written. https://github.com/rescript-lang/rescript-compiler/pull/6874 https://github.com/rescript-lang/rescript-compiler/pull/6881 https://github.com/rescript-lang/rescript-compiler/pull/6883
- Add `Js.globalThis` object binding. https://github.com/rescript-lang/rescript-compiler/pull/6909

#### :boom: Breaking Change

Expand Down
3 changes: 3 additions & 0 deletions jscomp/others/js.res
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,9 @@ Prefer `Js.Array2` over `Js.Array`, `Js.String2` over `Js.String`, etc. The latt
/** JS object type */
type t<'a> = {..} as 'a

/** JS global object reference */
@val external globalThis: t<'a> = "globalThis"

/**
Nullable value of this type can be either null or 'a. This type is equivalent to Js.Null.t.
*/
Expand Down
3 changes: 3 additions & 0 deletions jscomp/runtime/js.res
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,9 @@ Prefer `Js.Array2` over `Js.Array`, `Js.String2` over `Js.String`, etc. The latt
/** JS object type */
type t<'a> = {..} as 'a

/** JS global object reference */
@val external globalThis: t<'a> = "globalThis"

/**
Nullable value of this type can be either null or 'a. This type is equivalent to Js.Null.t.
*/
Expand Down