Skip to content

Fix playground bundle API #7486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 18, 2025
Merged

Fix playground bundle API #7486

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5fb190c
playground: set global for the compatibility reason
cometkim May 18, 2025
f6b475c
Revert "playground: set global for the compatibility reason"
cometkim May 18, 2025
e3092fc
Use unsafe API instead of PPX, which is even more unsafe
cometkim May 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions compiler/jsoo/dune
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,4 @@
(= %{profile} browser))
(flags
(:standard -w +a-4-9-40-42-44-45))
(libraries core syntax ml js_of_ocaml)
(preprocess
(pps js_of_ocaml-ppx)))
(libraries core syntax ml js_of_ocaml))
12 changes: 7 additions & 5 deletions compiler/jsoo/jsoo_playground_main.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -675,8 +675,10 @@ end

let () =
Js.export "rescript_compiler"
(object%js
val api_version = api_version
val version = Bs_version.version
method make = Export.make ()
end)
Js.Unsafe.(
obj
[|
("api_version", inject @@ Js.string api_version);
("version", inject @@ Js.string Bs_version.version);
("make", inject @@ Export.make);
|])
1 change: 0 additions & 1 deletion rescript.opam
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ depends: [

# Test dependencies that would be broken on Windows runners
"js_of_ocaml" {os != "win32" & with-test & = "6.0.1"}
"js_of_ocaml-ppx" {os != "win32" & with-test & = "6.0.1"}
"wasm_of_ocaml-compiler" {os != "win32" & with-test & = "6.0.1"}
]
pin-depends: [
Expand Down
1 change: 0 additions & 1 deletion rescript.opam.template
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ depends: [

# Test dependencies that would be broken on Windows runners
"js_of_ocaml" {os != "win32" & with-test & = "6.0.1"}
"js_of_ocaml-ppx" {os != "win32" & with-test & = "6.0.1"}
"wasm_of_ocaml-compiler" {os != "win32" & with-test & = "6.0.1"}
]
pin-depends: [
Expand Down