Skip to content

Adapt bsb to new rescript.json flags and remove usage of deprecated ones #7699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 23, 2025
Merged

Adapt bsb to new rescript.json flags and remove usage of deprecated ones #7699

merged 2 commits into from
Jul 23, 2025

Conversation

cknitt
Copy link
Member

@cknitt cknitt commented Jul 22, 2025 •
edited
Loading

  • Remove usage of deprecated "bs*" flags in the various rescript.jsons in the repo
  • Adapt bsb to recognize the new flags

@cknitt cknitt marked this pull request as draft July 22, 2025 18:30
@cknitt cknitt changed the title Remove usage of deprecated rescript.json flags Adapt bsb to new rescript.json flags and remove usage of deprecated ones Jul 23, 2025
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Jul 23, 2025

Open in StackBlitz

rescript

npm i https://pkg.pr.new/rescript-lang/rescript@7699

@rescript/darwin-arm64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/darwin-arm64@7699

@rescript/darwin-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/darwin-x64@7699

@rescript/linux-arm64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/linux-arm64@7699

@rescript/linux-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/linux-x64@7699

@rescript/win32-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/win32-x64@7699

commit: 6c5b82f

@cknitt cknitt marked this pull request as ready for review July 23, 2025 06:58
@cknitt cknitt requested a review from zth July 23, 2025 06:58
@cknitt cknitt merged commit 86f026c into master Jul 23, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zth zth zth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cknitt @zth