Skip to content

Complete react.componentWithProps #7812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 27, 2025
Merged

Complete react.componentWithProps #7812

merged 2 commits into from
Aug 27, 2025

Conversation

nojaf
Copy link
Member

@nojaf nojaf commented Aug 27, 2025

No description provided.

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Aug 27, 2025 •
edited
Loading

Open in StackBlitz

rescript

npm i https://pkg.pr.new/rescript-lang/rescript@7812

@rescript/darwin-arm64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/darwin-arm64@7812

@rescript/darwin-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/darwin-x64@7812

@rescript/linux-arm64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/linux-arm64@7812

@rescript/linux-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/linux-x64@7812

@rescript/runtime

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/runtime@7812

@rescript/win32-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/win32-x64@7812

commit: 0fe358f

@nojaf nojaf marked this pull request as ready for review August 27, 2025 12:10
zth
zth approved these changes Aug 27, 2025
View reviewed changes
Copy link
Member

@zth zth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Curious, I wonder if we have tests for this being able to produce actual prop completions as well.

@nojaf nojaf merged commit 42dfb71 into rescript-lang:master Aug 27, 2025
25 checks passed
@nojaf
Copy link
Member Author

nojaf commented Aug 27, 2025

We probably don't have any tests covering this, but completion does work, just tested that.

@zth
Copy link
Member

zth commented Aug 27, 2025

We probably don't have any tests covering this, but completion does work, just tested that.

That's great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zth zth zth approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nojaf @zth