Extend Gentype shims #7842
Merged
Extend Gentype shims #7842
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR extends gentype support for stdlib types by adding comprehensive mappings for JavaScript built-in types without requiring TypeScript shims. It creates a new test project to verify that stdlib types can be properly mapped to their TypeScript equivalents through gentype.
- Adds new gentype mappings for typed arrays, iterators, Intl objects, and other JS builtins
- Creates a comprehensive test suite with no-shims configuration to validate the mappings
- Integrates the new test project into the main build and clean processes
Reviewed Changes
Copilot reviewed 11 out of 12 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
tests/gentype_tests/stdlib-no-shims/ |
New test project with TypeScript config, ReScript source, and build files |
compiler/gentype/TranslateTypeExprFromTypes.ml |
Adds gentype mappings for 40+ stdlib types to their TS equivalents |
Makefile |
Integrates new test project into build and clean targets |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
rescript
@rescript/darwin-arm64
@rescript/darwin-x64
@rescript/linux-arm64
@rescript/linux-x64
@rescript/runtime
@rescript/win32-x64
commit: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new test project for gentype where no shims are set up, and adds a bunch of new mappings for the stdlib that previously wasn't there.
Intention is to have a central place to add tests for all the things from the stdlib/builtins we expect gentype to map without needing shims.
Part of #7835.