Skip to content

Conversation

tsnobip
Copy link
Member

@tsnobip tsnobip commented Oct 2, 2025

fixes #7931.

Copy link

pkg-pr-new bot commented Oct 2, 2025

Open in StackBlitz

rescript

npm i https://pkg.pr.new/rescript-lang/rescript@7933

@rescript/darwin-arm64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/darwin-arm64@7933

@rescript/darwin-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/darwin-x64@7933

@rescript/linux-arm64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/linux-arm64@7933

@rescript/linux-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/linux-x64@7933

@rescript/runtime

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/runtime@7933

@rescript/win32-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/win32-x64@7933

commit: 0730463

@tsnobip tsnobip requested a review from cknitt October 2, 2025 11:00
@cknitt
Copy link
Member

cknitt commented Oct 2, 2025

Thank you! I think we should also fix this for Belt though.

@tsnobip
Copy link
Member Author

tsnobip commented Oct 2, 2025

Thank you! I think we should also fix this for Belt though.

@cknitt We're usually very careful about changing Belt API, should we fix it (it's not wrong per se given it's documented like this, it's just very weird) there now or should we wait for a later moment when we finally decide to introduce all these breaking changes to Belt at once?

@tsnobip tsnobip requested a review from cknitt October 3, 2025 07:48
@cknitt
Copy link
Member

cknitt commented Oct 3, 2025

@tsnobip doesn't build yet, you forgot to commit the updated JS output.

@tsnobip tsnobip merged commit 112ebd5 into master Oct 3, 2025
36 of 37 checks passed
@tsnobip tsnobip deleted the fix-result-equal branch October 3, 2025 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implementation of Result.equal and Result.compare treats all errors as equal
2 participants