This repository was archived by the owner on Jun 15, 2023. It is now read-only.
Better error message on capitalized type #424
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryyppy
commented
May 26, 2021
src/res_core.ml
Outdated
| | Dot -> parseValuePathTail p startPos (Longident.Lident ident) | ||
| | _ -> | ||
| Parser.err p ~startPos:identStartPos ~endPos:identEndPos (Diagnostics.message "Type names need to start with a lower-cased letter."); | ||
| Location.mkloc (Longident.Lident ident) (mkLoc identStartPos identEndPos) |
There was a problem hiding this comment.
Not sure if startPos / endPos is correct here
|
Probably worth adding a suggestion in the error message as well: |
|
Yes, definitely worth a try. In general I like having an error message follow the format "what" + "this-is-how-you-could-fix-it". |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First attempt tackling #122
There are a few tests breaking bc of this, not sure how to solve them.