This repository has been archived by the owner on Jun 15, 2023. It is now read-only.
Fix support for recursive components in JSX4 #733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mununki
force-pushed
the
recursive-component-v4
branch
from
d9c2649
to
9220ef9
Compare
cristianoc
approved these changes
Feb 6, 2023
cli/reactjs_jsx_v4.ml
Outdated
| @@ -1228,7 +1233,8 @@ let transformStructureItem ~config mapper item = | |||
| List.fold_right otherStructures structuresAndBinding ([], [], []) | |||
| in | |||
| types | |||
| @ [{pstr_loc; pstr_desc = Pstr_value (recFlag, bindings)}] | |||
| (* No need to be Recursive as internal representation is called *) | |||
| @ [{pstr_loc; pstr_desc = Pstr_value (Nonrecursive, bindings)}] | |||
There was a problem hiding this comment.
This does not work with mutually recursive components. See example in the original PR.
cristianoc
reviewed
Feb 6, 2023
| make(({}: props)) | ||
| } | ||
| let make = { | ||
| let \"V4$Rec" = props => \"make$Internal"(props) |
There was a problem hiding this comment.
This part seems to be doing noting in the case of recursive functions.
That was true already before, so that's OK. Just, not very useful.
There was a problem hiding this comment.
Since recursive components are rare, let's just move on.
There was a problem hiding this comment.
This part seems to be making this expression in js output:
function make(_props) {
while(true) {
_props = {};
continue ;
};
}
var V4$Rec = { // <- here
make: make
};
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue rescript-lang/rescript-compiler#5981, backporting rescript-lang/rescript-compiler#5986 to syntax