Skip to content

Conversation

drish
Copy link
Collaborator

@drish drish commented Sep 21, 2025

  • Domains
  • Audiences
  • Api Keys
  • Contacts
  • Broadcasts

Summary by cubic

Adds optional pagination to list methods for API Keys, Audiences, Broadcasts, Contacts, and Domains, enabling limit/after/before queries and returning pagination metadata. Updated examples and tests to demonstrate and verify the new behavior.

  • New Features
    • List methods accept optional params: limit, after, before.
    • List responses include object: "list" and has_more.
    • Added PaginationHelper to build query strings safely (filters None, preserves existing queries).
    • Updated examples to show paginated usage for each resource.
    • Added comprehensive tests for list pagination and the helper.

@drish drish requested a review from lucasfcosta September 21, 2025 20:33
Copy link

@lucasfcosta lucasfcosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just one minor suggestion about the docstrings on whether we want to make it more explicit that not passing limit will not paginate. Just in case people think we'll paginate to the max (100 results) by default (which we don't do).

@drish drish merged commit 9384677 into main Sep 23, 2025
19 checks passed
@drish drish deleted the feat/optional-pagination-list-methods branch September 23, 2025 03:31
drish added a commit that referenced this pull request Oct 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants