Skip to content

Conversation

avigoldman
Copy link
Contributor

Currently, if you run the example you get the following error:

Potentially unhandled rejection [1] Error: Unrecognized node type: undefined
Node: "HELLO WORLD"

This is because you override the object { type: 'text', content: 'Hello world', location: ... } with the string HELLO WORLD.

This PR reassigns the content instead of overriding the object.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 09ded00 on avigoldman:patch-1 into 5ec335b on reshape:master.

@jescalan
Copy link
Member

jescalan commented Feb 3, 2018

Thanks for catching this and contributing the fix! 🙌

@jescalan jescalan merged commit f1e235d into reshape:master Feb 3, 2018
@avigoldman avigoldman deleted the patch-1 branch February 3, 2018 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants