Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add visual element to differentiate front and back of the robot #11

Closed
wants to merge 7 commits into from

Conversation

dogoepp
Copy link
Member

@dogoepp dogoepp commented Sep 15, 2016

I propose to add a visual element to differentiate the front and back of the robots in RVIZ. See bellow for the proposed display.

rviz_marta_with_head

I also made the body colours different between the new hexapod and Pexod.

Do you have other proposals for the appearance ?

@costashatz
Copy link
Member

See bellow for the proposed display.

I do not really like it like this. We could put something like an Xtion facing front or a camera? See below.

I also made the body colours different between the new hexapod and Pexod.

We need to change the appearance of the hexapods a lot. The best thing to do would be to put actual STLs and just keep very simple the collision parts. If we cannot do that, we could just change the colors to something more subtle [not so bright](like grayish, blueish etc).

@dogoepp
Copy link
Member Author

dogoepp commented Sep 15, 2016

What bellow ?

@costashatz
Copy link
Member

What bellow ?

Oops! Forgot to erase. At first I had 2 paragraphs that were linked, but then I changed it.

What do you think about the STLs? Do you have time? Do we actually have them?

@dogoepp
Copy link
Member Author

dogoepp commented Sep 15, 2016

I'm looking for Robotis' STLs. I'll see if it's an easy job or not. The idea of actually having the robot displayed is nice, as long as it does not last too long. I'm not too passionate about handling Xacro and URDF files.

@costashatz
Copy link
Member

I'm looking for Robotis' STLs. I'll see if it's an easy job or not. The idea of actually having the robot displayed is nice, as long as it does not last too long. I'm not too passionate about handling Xacro and URDF files.

I totally agree with you. If it takes too long, just leave it as it is and change the colors. Try this website for color chooser.

@dogoepp
Copy link
Member Author

dogoepp commented Sep 15, 2016

I'm happy with the colours as they are. You can make your proposals if
you wish to have something else.

What about discussing this again when you're back ? I tried putting the
STL and although I can display things, I have a few questions for you

Le 15/09/2016 à 09:58, Konstantinos Chatzilygeroudis a écrit :

I'm looking for Robotis' STLs. I'll see if it's an easy job or
not. The idea of actually having the robot displayed is nice, as
long as it does not last too long. I'm not too passionate about
handling Xacro and URDF files.

I totally agree with you. If it takes too long, just leave it as it is
and change the colors. Try this website
http://paletton.com/#uid=1000u0kllllaFw0g0qFqFg0w0aF for color chooser.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#11 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AMmndN6jgUPpBqh6sqyQk7nipgtoTh2Zks5qqPqugaJpZM4J9iqP.

@costashatz
Copy link
Member

I'm happy with the colours as they are. You can make your proposals if
you wish to have something else.

OK. I will do something.

What about discussing this again when you're back ? I tried putting the
STL and although I can display things, I have a few questions for you

Yeap. Sure!

Dorian Goepp added 2 commits October 7, 2016 14:55
Actually, Marta was the temporary name and Hexaforce has been now chosen.
@costashatz
Copy link
Member

@dogoepp can you put a photo? 😄

@dogoepp
Copy link
Member Author

dogoepp commented Oct 7, 2016

Can you ?

@dogoepp
Copy link
Member Author

dogoepp commented Oct 7, 2016

It would be a nice test for the many changes, including the renaming from Marta to Hexaforce.

@dogoepp
Copy link
Member Author

dogoepp commented Oct 11, 2016

Here goes a screenshot
rviz_hexaforce_stls

@costashatz
Copy link
Member

That's very nice @dogoepp! Good work! I will put the Xtion instead of the box to show the direction.. I like it very much..

@dogoepp
Copy link
Member Author

dogoepp commented Oct 11, 2016

Could you review both the models for Pexod and Hexaforce, so that we can safely merge this ?

@costashatz
Copy link
Member

Could you review both the models for Pexod and Hexaforce, so that we can safely merge this ?

I will try to do it tomorrow. I need to also check the controller in DART.. Thanks for the updates!

@dogoepp
Copy link
Member Author

dogoepp commented Oct 25, 2016

Did you find time to try a bit the models. I believe that at least one
of them has mistakes.

Le 11/10/2016 à 15:46, Konstantinos Chatzilygeroudis a écrit :

Could you review both the models for Pexod and Hexaforce, so that
we can safely merge this ?

I will try to do it tomorrow. I need to also check the controller in
DART.. Thanks for the updates!


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#11 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AMmndOK1oHwSvGNaX1Jh6W4_LsuMJK0sks5qy5M9gaJpZM4J9iqP.

@dogoepp
Copy link
Member Author

dogoepp commented Nov 28, 2016

When do you think you could spend some time testing these models in the simulator ?

@costashatz
Copy link
Member

When do you think you could spend some time testing these models in the simulator ?

Mid of December (around the 15th)..

@dogoepp
Copy link
Member Author

dogoepp commented Nov 28, 2016 via email

@dogoepp
Copy link
Member Author

dogoepp commented Jan 19, 2017

Is there any reason not to merge this pull request ?

@costashatz
Copy link
Member

Is there any reason not to merge this pull request ?

Not really, except from the fact that I haven't checked the new models in simulation.. I will try to do it soon so that we can merge...

@dogoepp dogoepp closed this Jan 19, 2017
@costashatz
Copy link
Member

@dogoepp Why did you close it?

@dogoepp
Copy link
Member Author

dogoepp commented Jan 19, 2017

I just did it, unwillingly. It should not matter since these changes are not merged into master. Let's say the topic of this pull request is to check the models and then merge into master.

@dogoepp
Copy link
Member Author

dogoepp commented Feb 28, 2017 via email

@costashatz
Copy link
Member

Can I assume that appart from commit a7b68c6 the changes
introduced here are OK for you ?

I think yes, but before merging to master we need to check the simulation if it is ok..

@dogoepp dogoepp deleted the hexapod_heads branch July 11, 2017 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants