✅ Test different versions of resque and redis #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using Appraisal to generate the gemfiles
While these theoretically might be useful for catching some weird edge-case bugs, it doubles the number of CI builds. So, instead we'll just include a single runner for the older OS.
nevans
force-pushed
the
appraisal
branch
7 times, most recently
from
90fbd9d
to
25e15e8
Compare
With a little effort, some of these could be made compatible, but... it's really not worth the effort. We'll be dropping support for older versions from the next minor release anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using Appraisal to generate the gemfiles.
The test matrix is huge, with 96 checks (at the latest count). But I want to drop support for older versions in a separate PR.