Skip to content

Don't try to handle Error #376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 9, 2024
Merged

Don't try to handle Error #376

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions sdk-api-kotlin/src/main/kotlin/dev/restate/sdk/kotlin/ContextImpl.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,8 +173,6 @@ internal class ContextImpl internal constructor(private val syscalls: Syscalls)
actionReturnValue = block()
} catch (e: TerminalException) {
actionFailure = e
} catch (e: Error) {
throw e
} catch (t: Throwable) {
syscalls.fail(t)
throw CancellationException("Side effect failure", t)
Expand Down
4 changes: 0 additions & 4 deletions sdk-api-kotlin/src/main/kotlin/dev/restate/sdk/kotlin/HandlerRunner.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,8 +63,6 @@ internal constructor(
val req: REQ
try {
req = handlerSpecification.requestSerde.deserialize(syscalls.request().bodyBuffer())
} catch (e: Error) {
throw e
} catch (e: Throwable) {
LOG.warn("Error when deserializing input", e)
throw TerminalException(
Expand All @@ -77,8 +75,6 @@ internal constructor(
// Serialize output
try {
serializedResult = handlerSpecification.responseSerde.serializeToByteBuffer(res)
} catch (e: Error) {
throw e
} catch (e: Throwable) {
LOG.warn("Error when serializing input", e)
throw TerminalException(
Expand Down
2 changes: 0 additions & 2 deletions sdk-api/src/main/java/dev/restate/sdk/ContextImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,8 +168,6 @@ public void onCancel(@Nullable Throwable t) {
res = action.get();
} catch (TerminalException e) {
failure = e;
} catch (Error e) {
throw e;
} catch (Throwable e) {
syscalls.fail(e);
AbortedExecutionException.sneakyThrow();
Expand Down
6 changes: 0 additions & 6 deletions sdk-api/src/main/java/dev/restate/sdk/HandlerRunner.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,8 +69,6 @@ public void run(
try {
req =
handlerSpecification.getRequestSerde().deserialize(syscalls.request().bodyBuffer());
} catch (Error e) {
throw e;
} catch (Throwable e) {
LOG.warn("Cannot deserialize input", e);
callback.onCancel(
Expand All @@ -84,8 +82,6 @@ public void run(
RES res;
try {
res = this.runner.apply(ctx, req);
} catch (Error e) {
throw e;
} catch (Throwable e) {
callback.onCancel(e);
return;
Expand All @@ -95,8 +91,6 @@ public void run(
ByteBuffer serializedResult;
try {
serializedResult = handlerSpecification.getResponseSerde().serializeToByteBuffer(res);
} catch (Error e) {
throw e;
} catch (Throwable e) {
LOG.warn("Cannot serialize output", e);
callback.onCancel(
Expand Down
Loading