Skip to content

Conversation

jackkleeman
Copy link
Contributor

@jackkleeman jackkleeman commented Jun 17, 2024

  1. Remove Object.hasOwn as LLRT doesn't implement it
  2. Inline Node's implementations of the uint64 buffer functions as neither workers nor llrt supports it
  3. Remove assert as neither workers nor llrt supports it (and its a single line :p)
  4. Remove async_hooks as this is not standardised and cannot be polyfilled without runtime support. Fall back on the flag which says whether we are currently executing a run

Copy link

Test Results

102 files  ±0  102 suites  ±0   20m 3s ⏱️ +15s
 84 tests ±0   84 ✅ ±0  0 💤 ±0  0 ❌ ±0 
215 runs  ±0  215 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 146889d. ± Comparison against base commit 7f93b65.

@igalshilman igalshilman self-requested a review June 17, 2024 10:00
Copy link
Contributor

@igalshilman igalshilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackkleeman jackkleeman merged commit dcb7dba into main Jun 17, 2024
@jackkleeman jackkleeman deleted the denodeify-2 branch June 17, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants