Use eslint to require import and export type statements #379
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igalshilman
approved these changes
Jun 17, 2024
This is something esm requires, although in theory typescript can try and figure it out for us, this is no longer recommended.
igalshilman
reviewed
Jun 17, 2024
| import type { PaymentWorkflow } from "./workflow"; | ||
| import type { Counter } from "./object"; |
There was a problem hiding this comment.
This should be type tho
igalshilman
reviewed
Jun 17, 2024
| IngresCallOptions, | ||
| SendOpts, | ||
| Send, | ||
| IngresSendOptions, |
There was a problem hiding this comment.
Not sure about this one
jackkleeman
added a commit
that referenced
this pull request
Jun 17, 2024
This reverts commit d46f4dd.
jackkleeman
added a commit
that referenced
this pull request
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is something esm requires, although in theory typescript can try and figure it out for us, this is no longer recommended (they recommend
verbatimModuleSyntaxtrue), because some things have side effects just from being imported, so its important to know if you're importing the type or not.PR is generated simply by running
npx eslint --fix --ignore-path .eslintignore --max-warnings=0 --ext .ts .