Package refresh #100
Package refresh #100
Conversation
|
Hello @DonutEspresso @hekike 👋 |
| * @type {Function} | ||
| */ | ||
| if (opts.hasOwnProperty('toJSON')) { | ||
| if (Object.prototype.hasOwnProperty.call(opts, 'toJSON')) { |
There was a problem hiding this comment.
Why the conversion to .call?
There was a problem hiding this comment.
It is the autofix of following eslint rule no-prototype-builtins, that got added into eslint:recommended config
|
@retrohacker Thanks for the review. |
|
@AdrieanKhisbe no need, we use conventional commits so have to squash and merge anyways 😄 Thank you for contributing ❤️ |
|
@retrohacker Thanks! =) About the refreshception proposal, that was more to ensure to upgrade dependencies were latest if some were updated since the moment I made the Pull Request :) Little question, do when you plan to publish ? :) |
|
Hello @retrohacker Thanks a lot in advance! :) |
|
👋 @retrohacker @hekike @DonutEspresso. Some last "draw attention attempt" until summer, so we can have latest Thanks in advance for your time, and really sorry for these messages. |
Hello :)
Here is some upgrade for the package!
Was considering, replacing the Makefile with standard npm scripts.
But I prefered to check first if you're okay with it ? :)
(cc @DonutEspresso @hekike )
If so, tell me. I'll add it to the PR