Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double uppercase issue #1601

merged 2 commits into from Jul 15, 2021


Copy link

@shipsaw shipsaw commented Jun 25, 2021


This addresses an issue brought up in #1471 where attributes that ended in "ID" (or any sequence of upper-case letters) was not able to match with properties where those two letters were also both capitalized (i.e. "id", "Id"). I didn't see in the docs that case-insensitive matching was a requirement, but for many people it seems that it is implied.

Addressing this issue in the GetNameVariants method in StringExtensions.cs would seem to involve a lot of extra methods just to achieve a case-insensitive comparison, so I updated the Map method to create a new case-insensitive dictionary rather than simply referencing the previous one.


This pull request is a:

  • [x ] Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)


  • [ x] I have added tests that prove my fix is effective or that my feature works
  • [x ] I have added necessary documentation (if appropriate)

@alexeyzimarev alexeyzimarev merged commit c544837 into restsharp:dev Jul 15, 2021
3 of 4 checks passed
@shipsaw shipsaw deleted the double_uppercase_issue branch Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants