Skip to content

Conversation

alexeyzimarev
Copy link
Member

When deserializing the response, RestClient changes the properties of the deserializer to match the request. Which means the shared deserializer instance changes per request, and keep the last request value, so it's not thread-safe and not side-effect-free. Here we change the behaviour to instantiate serializer per request, which makes it possible to change properties for a given request only.

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Dec 17, 2021

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 3d5c59d
Status: ✅  Deploy successful!
Preview URL: https://2f30da05.restsharp.pages.dev

View logs

@alexeyzimarev alexeyzimarev merged commit 5830af4 into dev Dec 17, 2021
@repo-ranger repo-ranger bot deleted the fixing-xml branch December 17, 2021 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant