Skip to content

Conversation

friism
Copy link
Contributor

@friism friism commented Dec 30, 2011

No description provided.

@petejohanson
Copy link
Contributor

@friism Thanks for the patch!

What is your use case for this? Are you using a RestRequest with a String.Empty resource or something?

Also, this would need test(s) added to RestSHarp.Tests.UrlBuilderTests before being merged.

Thanks.

@friism
Copy link
Contributor Author

friism commented Jan 25, 2012

I've added some unit tests. The use case is that I create the client with the full uri (which comes from user input), and I need RestSharp to not slab slashes at the end of the uri willy-nilly. http://example.com/resource is semantically different from http://example.com/resource/.

Thanks!

@friism
Copy link
Contributor Author

friism commented Jan 31, 2012

bump

@cbertolasio
Copy link

this issue bit me today. I dont understand why restsharp needs to assume that I want a "/" on the end of my URI.

@friism
Copy link
Contributor Author

friism commented Feb 8, 2012

I think they're not merging because it's a breaking change for people who like being bitten.

johnsheehan added a commit that referenced this pull request Feb 8, 2012
don't add trailing slash if assembled is null
@johnsheehan johnsheehan merged commit db44f42 into restsharp:master Feb 8, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants