Fix for XmlDeserializer issue not handling lowercase + dash root elements in some cases

[zidad]

Added a fix and a unit test for the issue: #269

The checkin consist of a new test:
Can_Deserialize_Root_Elements_Without_Matching_Case_And_Dashes

Which will deserialze a structure like this:

<incoming-invoices>
<incoming-invoice>
...
<incoming-invoice>
</incoming-invoices>

To a List <IncomingInvoice>

[johnsheehan]

if existing tests pass too, this is good to pull

[zidad]

Ok thanks, they pass fine...

[zidad]

Hi John,

Do you have a time frame when this can be merged, or is there anything I can do?

[SaintGimp]

Bump - would like to see this merged.

[brendanc]

Yeah, think I just submitted a similar/same pull request. I'll withdraw mine, would love to see this get merged in.

[SaintGimp]

By the way, it looks like xml attributes have the same sort of bug which isn't addressed by this pull request. Seems like trying all the different convention mappings is something that could be extracted into a reusable piece of code, right?

[zidad]

@SaintGimp Sounds like a good idea... @johnsheehan I finally learned about rebasing (;0) so I if it makes it easier for you I could probably create a cleaner pull request?

[petejohanson]

Instead of removing this existing test for LowercaseUnderscores, can we supplement the lowercase underscores test with an additional test for dashes? Doing so will help us ensure both deserialization approaches stay working after future changes.

[petejohanson]

Ok, merged, and I restored the one existing test to make sure we cover both cases, and did some minor whitespace fixes.

Thanks for the contribution!

[zidad]

Thanks! Any idea when this is released to a nuget package, or is there feed somewhere?

[petejohanson]

@ayoung released a new build 103.2 today to nuget.org. You should be able to update and have the change.

[zidad]

Got it, thanks!