Fixed Json deserialization (null string elements in lists) #286
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Null strings in lists crashed the deserialization. Now, null strings are added as null elements to the product of JsonDeserializer.BuildList().
|
Needs associated unit tests. No changes to the deserializers without tests. |
|
It looks like you may not have had your EOL configuration for git properly configured when commiting this change. Can you please try setting "core.autocrlf" to "true" and committing this change in a new branch/PR? |
petejohanson
added a commit
that referenced
this pull request
Jun 29, 2012
|
I've just implemented this, including the test, with the current JsonDeserializer. Please test with the latest version and let me know if you have any problems. If so, please feel free to open a new Issue/PR. Thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Null strings in lists crashed the deserialization. Now, null strings are
added as null elements to the product of JsonDeserializer.BuildList().