MonoTouch: Issue 293: JsonDeserialzer crashes on generic lists

[nicwise]

Bug records:

#293

https://bugzilla.xamarin.com/show_bug.cgi?id=6031

In MonoTouch, the changed line of code (without the change) causes an issue, as the list of interfaces CAN include non-generic types, and the ordering is not fixed, so you can get a non-generic type first. Calling GetGenericTypeDefinition on a non-generic crashes things.

If the code checks for it being generic first:

var listType = type.GetInterfaces().First(x => x.IsGenericType && x.GetGenericTypeDefinition() == typeof(IList<>));

then it doesn't fail.

[nicwise]

Sorry, not well explained. In MonoTouch, the changed line of code (without the change) causes an issue, as the list of interfaces CAN include non-generic types, and the ordering is not fixed, so you can get a non-generic type first.

If the code checks for it being generic first:

var listType = type.GetInterfaces().First(x => x.IsGenericType && x.GetGenericTypeDefinition() == typeof(IList<>));

then it doesn't fail.

[petejohanson]

Thanks for the investigation and pull request!

[nicwise]

No problem. Thankfully, once I got the confirmation of whats going on under the hood from Marek at Xamarin, it was an easy one. (Can't say I did much of the work tho :) )

[ayoung]

Thanks Nic. Those Xamarin guys always have good support.

[nicwise]

that they do. thanks for the help