Added clearer comments for RestRequest.AddBody and additional RestRequest.AddJsonBody and RestRequest.AddXmlBody #573
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 182b025.
This reverts commit 182b025.
It can be unintuitive that you need to first specify the RequestFormat is JSON to have the RestRequest serialize data to JSON. This leads to hard to debug HTTP responses saying that the JSON format is incorrect, because by default the data is serialized to XML. This is further compounded by endless suggestions on popular forums and message boards that you manually need to set the ‘Content-Type’ header to be ‘application/json’ making this a difficult product to use out of the box.
|
@davidgrupp this PR can't be auto merged. can you pull the latest from master and resolve any conflicts so I can merge it in? |
|
@hallem I mereged and the conflicts should be resolved. Thanks |
hallem
added a commit
that referenced
this pull request
Oct 23, 2014
Added clearer comments for RestRequest.AddBody and additional RestRequest.AddJsonBody and RestRequest.AddXmlBody
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It can be unintuitive that you need to first specify the RequestFormat is JSON to have the RestRequest serialize data to JSON. This leads to hard to debug HTTP responses saying that the JSON format is incorrect because by default the data is serialized to XML. This is further compounded by endless suggestions on popular forums and message boards that you manually need to set the ‘Content-Type’ header to be ‘application/json’ making this a difficult product to use out of the box.