Fixed bug where XmlDeserializer would not deserialize public nested type #582
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ypes The RestSharp XmlDeserializer only tries to deserialize types where Type.IsPublic is true. For nested public classes, Type.IsPublic is false, but Type.IsNestedPublic is true . Updated deserializer to check for this condition
hallem
added a commit
that referenced
this pull request
Oct 19, 2014
Fixed bug where XmlDeserializer would not deserialize public nested type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The RestSharp XmlDeserializer only tries to deserialize types where
Type.IsPublic is true. For nested public classes, Type.IsPublic is
false, but Type.IsNestedPublic is true . Updated deserializer to check
for this condition