Skip to content

avoid rebuilding the Basic Authentication header for each request #616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 17, 2014
Merged

avoid rebuilding the Basic Authentication header for each request #616

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions RestSharp/Authenticators/HttpBasicAuthenticator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,13 +22,12 @@ namespace RestSharp
{
public class HttpBasicAuthenticator : IAuthenticator
{
private readonly string _username;
private readonly string _password;
private readonly string _authHeader;

public HttpBasicAuthenticator(string username, string password)
{
_password = password;
_username = username;
var token = Convert.ToBase64String(Encoding.UTF8.GetBytes(string.Format("{0}:{1}", username, password)));
_authHeader = string.Format("Basic {0}", token);
}

public void Authenticate(IRestClient client, IRestRequest request)
Expand All @@ -43,10 +42,7 @@ public void Authenticate(IRestClient client, IRestRequest request)
// only add the Authorization parameter if it hasn't been added by a previous Execute
if (!request.Parameters.Any(p => p.Name.Equals("Authorization", StringComparison.OrdinalIgnoreCase)))
{
var token = Convert.ToBase64String(Encoding.UTF8.GetBytes(string.Format("{0}:{1}", _username, _password)));
var authHeader = string.Format("Basic {0}", token);

request.AddParameter("Authorization", authHeader, ParameterType.HttpHeader);
request.AddParameter("Authorization", _authHeader, ParameterType.HttpHeader);
}
}
}
Expand Down