Fix to issue in #466 and others. ExecuteTaskAsync should not throw exceptions #628
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… handling more consistent with sync
jacdevos
changed the title
|
Thanks for the PR. I'll try and take a look at it this weekend. |
hallem
added a commit
that referenced
this pull request
Jan 22, 2015
…tionsFixed Fix to issue in #522 and others. ExecuteTaskAsync should not throw exceptions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue seems to plague a lot of people.
Execute (sync) and ExecuteAsync handle exceptions by swallowing them and setting the Error properties on the response object. This change makes ExecuteTaskAsync also swallow its errors by NOT invoking taskCompletionSource.TrySetException(response.ErrorException) in RestClient.Async.cs.
The change in Http.Async.cs was simply to populate the ErrorException with a ResponseStatus.ToWebException() if empty, making it even more consistent with Execute (sync).
Most of the code changes were changes to tests that expected ExecuteTaskAsync to throw exceptions.