ServicePointManager to ServicePoint Change #634
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ServicePointManager.Expect100Continue = false; with webRequest.ServicePoint.Expect100Continue = false; The original version sets the default for future ServicePoints, not the current ServicePoint. I don't think setting the global default here is a great idea, and it doesn't affect the current ServicePoint which has already been created.
hallem
added a commit
that referenced
this pull request
Jan 28, 2015
ServicePointManager to ServicePoint Change: changes the behavior from setting the default for all future ServicePoints but not the current one to just setting the current one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ServicePointManager.Expect100Continue = false;
with
webRequest.ServicePoint.Expect100Continue = false;
The original version sets the default for all future ServicePoints, but not the
current ServicePoint. I don't think setting the global default here is a
great idea, and it doesn't even affect the current ServicePoint which has
already been created.
Setting the application global default down inside a library is a bad behavior to me. This could lead to unintended results elsewhere in the application that incorporates RestSharp.
I posted in the Google Group if anyone wants to discuss or would like more explanation.