Adding support for deserializing ISO 8601 durations as TimeSpan in JSON #644
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good so far. Thanks for the tests and the PR. I'll review it this week and get it merged in. |
hallem
added a commit
that referenced
this pull request
Mar 23, 2015
Adding support for deserializing ISO 8601 durations as TimeSpan in JSON
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears that ServiceStack's default serialization for TimeSpan is ISO 8601, which causes an exception during deserialization in RestSharp. XmlConvert handles this format, so we'll attempt normal TimeSpan.Parse and failing that, attempt XmlConvert.