Add AddHandler, RemoveHandler, DownloadData and ClearHandlers methods to IRestClient inteface. Add MaxRedirects and FollowRedirects properties to IRestClient interface. #656
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rty, and ClearHandlers method to IRestClient interface.
issafram
changed the title
issafram
changed the title
|
Thanks for the PR. I've taken a quick look and everything looks ok to me. I'll run the tests and make sure all the platforms compile and then merge it in. |
hallem
added a commit
that referenced
this pull request
Mar 23, 2015
Add AddHandler, RemoveHandler, DownloadData and ClearHandlers methods to IRestClient inteface. Add MaxRedirects and FollowRedirects properties to IRestClient interface.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I use the
IRestClientinterface for unit tests, etc.The interface is currently missing:
Methods
AddHandler,RemoveHandler,DownloadData, andClearHandlers.Properties
MaxRedirects, andFollowRedirects.I added a unit test to check the differences between the
RestClientclass and theIRestClientinterface.This would be a nice addition.
Let me know what you think or if something is missing.