Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ignore loading #154

Merged
merged 23 commits into from
Mar 25, 2019
Merged

Fix ignore loading #154

merged 23 commits into from
Mar 25, 2019

Conversation

beatngu13
Copy link
Contributor

I've reverted fc48b8a because Files.lines(…) in GlobalIgnoreApplier.load() doesn't read in the terminating empty line break at the end, which would again cause a diff in the VCS. However, I think this is already an improvement.

@beatngu13 beatngu13 requested a review from diba1013 March 21, 2019 18:25
@beatngu13 beatngu13 requested a review from diba1013 March 24, 2019 11:19
@beatngu13
Copy link
Contributor Author

I think I have now also resolved the file ending issue. JSShouldIgnoreLoader has:

@Override
public String save( final JSShouldIgnoreImpl ignore ) {
	return "";
}

Which creates unnecessary file content. I now filter it on save.

@beatngu13 beatngu13 requested a review from diba1013 March 25, 2019 08:20
@rebazer rebazer merged commit cb959ce into master Mar 25, 2019
@rebazer rebazer deleted the feature/fix-ignore-loading branch March 25, 2019 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants