-
-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rethinkdb-dump is broken #137
Comments
same issue |
Dear @epequeno, |
Ok, I tried to find my previous findings. So, the first argument is ignored (or it should be “dump”). This is why it tries to connect to localhost, because the parameter -c is ignored. The previous issue is #104. Unfortunately I did not realized that the discussion continued after I closed the issue, so I’ll need to touch this topic again. A long term solution would be to rewrite these command because they are (sometimes) over complicated, extremely hard to maintain and not tested at all |
My temporary solution was to to |
It turned out that what @alexa-infra fixed is totally OK, but we have the other issue: how we provide the scripts installed by We have two options here:
The root cause of the issue is that the optparser wants to parse the arguments like this: I would suggest to keep the dashed script names, indicate in the readme what kind of scripts we have, and parse the first argument as well. |
@gabor-boros It's possible to provide scripts like
instead of default shim files generated by setuptools for console_scripts |
@alexa-infra Yes, you are right. We should do this for the scripts. Also, I found that the other scripts parse the options in |
@alexa-infra could you please check #139 to see if you have any other ideas? Basically what you mentioned in this thread earlier ( |
@alexa-infra and @epequeno, the fix is released in 2.4.3.post1. Could you please confirm that the issue is fixed? Thank you in advance. |
@gabor-boros confirmed |
Due to the resolution is confirmed, I'm closing this issue |
Describe the bug
v2.4.3 tries to connect to localhost and ignores commandline arguments pointing to another host
v2.4.0 - v2.4.2.post1 error at
check_tls_option()
v2.3.0.post6 last working version
To Reproduce
Steps to reproduce the behavior:
rethinkdb-dump -c rethinkdb:28015 -f dump.tar.gz --tls-cert ./tls/rethinkdb-cert.pem --password-file pw
Expected behavior
A dump archive is successfully created without error
Errors
v2.4.3
v2.4.0 - v2.4.2.post1
System info
docker container built using
FROM python:3
The text was updated successfully, but these errors were encountered: