Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wait_closed dependency on Python <3.7 #304

Closed
srh opened this issue Oct 21, 2023 · 0 comments
Closed

Fix wait_closed dependency on Python <3.7 #304

srh opened this issue Oct 21, 2023 · 0 comments
Labels
bug Something isn't working not qualified The issue is not checked yet by the owners

Comments

@srh
Copy link
Contributor

srh commented Oct 21, 2023

Describe the bug
#267 uses an API that was added in Python 3.7, StreamWriter's wait_closed method. Prior to that, asyncio went out of its way to work with Python 3.5 and 3.6 (while the async def changes broke 3.4 for compatibility with later Python versions). We should branch on Python version to minimize breakage for older users.
@srh srh added bug Something isn't working not qualified The issue is not checked yet by the owners labels Oct 21, 2023
This was referenced Oct 21, 2023
Closed
Merged
@lsabi lsabi closed this as completed Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working not qualified The issue is not checked yet by the owners
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@srh @lsabi