Remove python 3.4 from build matrix (EOL) #111
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mehaase very good point! We need to remove it from Travis and both setup.py |
|
If you could extend the pr with removing the python 3.4 related stuff I would immediately merge the PR |
|
@mehaase , Nevermind, I'll do it later 😄 |
gabor-boros
approved these changes
Apr 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python 3.4 officially reached end-of-life (EOL) status on March 19, 2019.
As discussed here, we may want to remove it from the Travis build matrix. Not sure if we also want to remove it from the
setup.pytrove classifiers?