Feature/wildcard certs hostname #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What is the purpose of this change? I'm looking at https://docs.python.org/3/library/ssl.html and it seems to already support some kind of wildcard. |
|
Oh my god, it seems I really overlooked something o.O hostname shouldn't get a Thank you for recognizing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for the change
#124
Description
Ensure we can use subdomains in the hostname of SSL hostname matching, so we can connect to RethinkDB using wildcat SSL Certs.
Checklist
References
Anything else related to the change e.g. documentations, RFCs, etc.