Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(YouTube): Hide trending results during video search (non-litho how-to) #873

Closed
3 tasks done
0xrxL opened this issue May 26, 2023 · 10 comments
Closed
3 tasks done
Labels
Feature request Requesting a new feature that's not implemented yet

Comments

@0xrxL
Copy link

0xrxL commented May 26, 2023

Application

YouTube

Issue

UPDATE: Based on a recent feedback from @Aryan-Chauhan, the app now show two distinct type of trending results (with and without fire icon):
331839904-61ea83a4-253d-4e37-8dd0-50d5ab664e0f

Starting with the latest 18.1x versions, Google has introduced trending searches when searching for videos, as you can see in the screenshot below:

4

Patch

  • Create a method to hide/show the parent of a view, as shown in the following screenshot:
3
  • Pass the imageview of resource "R.drawable.yt_outline_fire_black_24" as parameters for the method "SearchSuggestionVisibility(imageView, boolean)", with parameter boolean set to "false", as shown in the following screenshot:
1
  • Pass the imageview of resource "R.drawable.yt_outline_arrow_time_black_24" and "R.drawable.yt_outline_search_black_24" as parameters for the method "SearchSuggestionVisibility(imageView, boolean)", with parameter boolean set to "true", as shown in the following screenshot:
2

Motivation

Remove useless and annoying searching results.

Acknowledgements

  • I have searched the existing issues and this is a new and no duplicate or related to another open issue.
  • I have written a short but informative title.
  • I filled out all of the requested information in this issue properly.
@0xrxL 0xrxL added the Feature request Requesting a new feature that's not implemented yet label May 26, 2023
@0xrxL 0xrxL changed the title feat: trending results during video search (non-litho) feat: how to hide trending results during video search (non-litho) May 26, 2023
@0xrxL
Copy link
Author

0xrxL commented May 26, 2023

Obviously...this patch ensure to leave "typing searching" untouched:

Immagine 2023-05-26 235727

@0xrxL
Copy link
Author

0xrxL commented May 26, 2023

YouTube 18.19.35 ---> kjz.smali

@Julius8900
Copy link

Those search trendings don't appear for me, instead the search history appears. Screenshot_2023-05-27-11-04-31-795_app.revanced.android.youtube-edit.jpg

Maybe it's some sort of A/B testing Google does at you.

@0xrxL
Copy link
Author

0xrxL commented May 27, 2023

Those search trendings don't appear for me, instead the search history appears. Screenshot_2023-05-27-11-04-31-795_app.revanced.android.youtube-edit.jpg

Maybe it's some sort of A/B testing Google does at you.

Yeah, but it can be patched before it is globally enabled.

@oSumAtrIX oSumAtrIX transferred this issue from ReVanced/revanced-patches-template Dec 14, 2023
@oSumAtrIX oSumAtrIX transferred this issue from another repository Dec 14, 2023
Slenderman00 pushed a commit to Slenderman00/revanced-patches-grindr that referenced this issue Jan 31, 2024
@LisoUseInAIKyrios LisoUseInAIKyrios changed the title feat: how to hide trending results during video search (non-litho) feat(YouTube): Hide trending results during video search (non-litho how-to) Apr 18, 2024
@Aryan-Chauhan
Copy link

Aryan-Chauhan commented May 19, 2024

I think it is now globally enabled for all users. Now there are 2 types of trending searches.

BTW, my search history is disabled & has zero items in it. Also, watch history is disabled & has zero items in it.

@0xrxL Can you edit your issue and include the below screenshot & mention that there are now 2 types of trending searches (fire & non-fire) ?

Untitled.png

@0xrxL
Copy link
Author

0xrxL commented May 19, 2024

Done (update added in the feature request description)

@0xrxL
Copy link
Author

0xrxL commented Aug 18, 2024

@LisoUseInAIKyrios Do you need of a new issue with steps to implement this feature, based on last 19.16.39 version?

@LisoUseInAIKyrios
Copy link
Contributor

If the information here is still valid then a new issue is not needed.

@0xrxL
Copy link
Author

0xrxL commented Oct 27, 2024

I can't see these results anymore.

Tested it on 3 accounts.

@0xrxL 0xrxL closed this as completed Oct 27, 2024
@Aryan-Chauhan
Copy link

Aryan-Chauhan commented Oct 28, 2024

Kindly re-open. I'm still getting them on both dev & stable patches with recommended version of APK (clean installation everytime).

Screenshot taken 1m ago.

Screenshot_2024-10-28-08-36-11-53_f22faf49515899f9781ec174a4d85388.jpg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature request Requesting a new feature that's not implemented yet
Projects
None yet
Development

No branches or pull requests

4 participants