Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error when --filter is empty #21

Merged
merged 3 commits into from
Jan 26, 2022
Merged

Fix error when --filter is empty #21

merged 3 commits into from
Jan 26, 2022

Conversation

ketozhang
Copy link
Contributor

If action argument inputs.filter was not set, then this would error since --filter must be non-empty if used:

$ cpplint --filter=${INPUT_FILTER} --recursive .

Changed the entrypoint script to only add these options when certain INPUT_* variables are set

@ketozhang ketozhang removed the request for review from srz-zumix January 25, 2022 04:18
@srz-zumix srz-zumix self-requested a review January 26, 2022 02:24
@srz-zumix srz-zumix merged commit 49b3507 into reviewdog:master Jan 26, 2022
@ketozhang ketozhang deleted the fix-empty-filter branch January 26, 2022 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants