[Android] Duplicate java spec files created with new architecture enabled

[Balthazar33]

Hi,
Thanks for maintaining revopush and ensuring its compatibility with the new RN versions.

On enabling the new architecture, the android build fails to generate due to duplicate native spec files getting created.

I have a custom native module in my android/app/src/newarch/java/com folder named ShortcutsModule.kt, with the corresponding specifications file in src/specs/NativeShortcutsModule.ts at the root of my project.

On trying to build the app with:

cd android && gradlew generateCodegenArtifactsFromSchema && gradlew clean && cd .. && npx react-native run-android

the NativeShortcutsModuleSpec.java file is created in the android/app/build/generated/source/codegen/java/com/appname folder of my project as well as the android folder of @revopush/react-native-code-push, which causes the build to fail.

Here's my react-native-config.js file:

module.exports = {
  project: {
    ios: {},
    android: {},
  },
  assets: ['./src/assets/fonts/'],
};

Also, I've added this line at the end of my android/app/build.gradle file:

apply from: "../../node_modules/@revopush/react-native-code-push/android/codepush.gradle"

Setup details:

React Native: 0.79.2
@revopush/react-native-code-push: 1.2.0
New architecture: enabled
buildToolsVersion = "35.0.0"
minSdkVersion = 24
compileSdkVersion = 35
targetSdkVersion = 35
ndkVersion = "27.1.12297006"
kotlinVersion = "2.1.20"

Can we prevent the native spec files from being generated under revopush?

Thanks.

[jaymengxy]

Hello, have you solved this problem? I have encountered the same situation.

[habasa]

It looks like Codegen is being executed twice, which causes duplicate Spec files to be generated. Because of this, projects with custom native modules can’t really use this package until the issue is resolved.

[kit2o]

@jaymengxy @habasa @Balthazar33 thanks for report we are working on resolving this issue now

[kit2o]

@jaymengxy @habasa @Balthazar33 we build a fix on this branch, please check it if it works for you we will make new release.

Use this version of Revopush which contains fix for Codegen in your package.json:

"@revopush/react-native-code-push": "github:revopush/react-native-code-push#native_module_fix"

then run npm i and rebuild android part of your app

[revopushbot]

any updates fro your side @jaymengxy @habasa @Balthazar33 ? We would love to have some confirmation from people except us that proposed fix helps. Thanks.

[revopushbot]

did you have chance to test @jaymengxy @habasa @Balthazar33 ?

[sefeb]

did you have chance to test @jaymengxy @habasa @Balthazar33 ?

Hi, i had the same problem in my react native project, and resolved it with this fix: "@revopush/react-native-code-push": "github:revopush/react-native-code-push#native_module_fix".

So, what is the next release version which contains this fix?

[revopushbot]

@sefeb thanks for confirming. release 1.4.0 contains a fix, please update

[revopushbot]

@jaymengxy @habasa @Balthazar33 please use 1.4.0 release with a fix.

[revopushbot]

fixed in 1.4.0