Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Save map and waypoint content on load, rather than on world save. #142

Closed
RokeJulianLockhart opened this issue Jun 22, 2024 · 2 comments

Comments

@RokeJulianLockhart
Copy link

RokeJulianLockhart commented Jun 22, 2024

I have a problem with my PC which causes it to crash regularly - PrismLauncher/PrismLauncher#2139 (comment) - and when it crashes whilst playing on my brother's LAN-hosted world, when I rejoin, all of my waypoints (and usually some of my map content) is deleted. Consequently, it should save the content when it changes rather than when the user disconnects. Hopefully this could be implemented in this, especially if #125 (comment) is accepted.

@RokeJulianLockhart RokeJulianLockhart changed the title Save map and waypoint content on load, rather than on world save. [Feature Request] Save map and waypoint content on load, rather than on world save. Jun 22, 2024
@rfresh2
Copy link
Owner

rfresh2 commented Jun 22, 2024

waypoints are already saved immediately on add or edit operations.

map data is saved async constantly because otherwise it would cause large fps spikes while it's writing to your hard drive.

the map data files themselves are megabytes in size and compressed, saves immediately on the render thread would have pretty significant performance impact

so it is still saved on changes, and its usually pretty quick after changes. just not immediately like when the chunks finish being loaded

@RokeJulianLockhart
Copy link
Author

#142 (comment)

@rfresh2, indeed. I and my brother have had to switch to https://www.curseforge.com/minecraft/mc-mods/journeymap/files/5208387 instead of Xaero because it would randomly delete map data for both of us, so I probably erroneously attributed it to the issue I was having. Glad to hear that it's designed well in the regard I wanted, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants