Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apple music update addresses issue #155 #158

Closed
wants to merge 2 commits into from
Closed

Apple music update addresses issue #155 #158

wants to merge 2 commits into from

Conversation

VishalBilagi
Copy link

No description provided.

@VishalBilagi VishalBilagi changed the title Apple music update Apple music update addresses issue #155 Oct 17, 2020
@pbnj
Copy link
Contributor

pbnj commented Oct 18, 2020

This means there would be 2 commands for music (m itunes & m music), which might be confusing to users when to use which.

Would it be possible to consolidate and determine based on OS version when to use itunes and when to use music?

If not, then I propose dropping itunes in favor of the new music command.

@VishalBilagi
Copy link
Author

Got it. I'll try doing that.

@bensleveritt
Copy link
Collaborator

Just to resurrect this: It'd be good to have one command (music), with a deprecation notice for itunes (no rush though), so I'm thinking of picking this up if you're happy @VishalBilagi ?

@VishalBilagi
Copy link
Author

Yeah, that will be possible. I'll try out something that checks OS version and runs appropriate command.

@VishalBilagi
Copy link
Author

But if you wanna go ahead and work on it, please go ahead. I don't know when I'll be able to finish it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants