Use mutable classpath api #354
Conversation
It now uses the mutable IClasspathEntryDescriptor API instead of the IClasspathEntry API.
|
I do not know why Travis is still failing. I can confirm that locally my change fixes the issue, and without my change the issue consistently appears. |
|
OK, i removed the |
|
I also removed the call to |
|
I can reproduce the issue you're seeing from the command line Maven build on my local machine. |
|
Maybe #344 is related. Let's wait for @fbricon's answer there. |
|
@rgladwell apart from technical advantages, this may (partially) solve #245. This is the order which is created for my project: Of course it does not replaces a complete sorter, for example if you delete src/main/resources, gen will be first. But if you do not delete anything, the order will be good with this PR. I think it can be merged, this is a valuable PR for multiple reasons. |
|
So this PR alone does not actually fix anything yet? We need fixes for #359 and #360 as well? |
|
Sorry that last comment sounded rude, I meant to say "this PR needs other code changes to fix #353?" |
|
This PR is a spinoff. I thought it will fix the problem, but it doesn't and it cannot. However this is still contains valuable changes, as i already tried to explain. This is not related to m2e 1.6, that was only my false assumption. I will update the misleading second commit message, sorry for not doing that before. |
They are now using the mutable IClassPathEntryDescriptor API, and directly mutating the existing entries instead of removing and adding new ones.
WonderCsabo
force-pushed
the
useMutableClasspathAPI
branch
from
2ea1404
to
1057f98
Compare
|
PR (commit message) updated. |
|
So I understand this is unrelated to #353, and this could be a fix for #245? Should we pull in the tests from #248 to verify this? |
|
I do not think so. This is just a refactor PR. It does not really fix that problem, only a subset of that, and only as a side effect. Let's forget #245 here. |
|
OK |
Related to #353.