Fix catastrophic backtracking with reference RegExp. Fixes issue #9. #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgrove
approved these changes
Apr 20, 2020
There was a problem hiding this comment.
Great catch. Thanks for the fix and the tests! I'll merge this shortly.
Given the way parse-xml constructs regexes, some of them can end up being pretty complex, which could mean there are other potentially pathological cases that are harder to spot than this one. I'll try to find some time to do some investigation around this.
|
👍 thanks for the library and the quick merge / publish! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR excludes
&from the reference regex. I have not checked over any other regexes for any other backtracking issues.